Messages in this thread |  | | | Date | Mon, 10 Dec 2007 08:18:04 +0100 (CET) | | From | Julia Lawall <> | | Subject | Re: [PATCH 3/3] Fix use of skb after netif_rx |
> > // </smpl> > > > > diff a/drivers/s390/net/ctcmain.c b/drivers/s390/net/ctcmain.c > > diff a/drivers/s390/net/netiucv.c b/drivers/s390/net/netiucv.c > > Julia, seems that your semantic patch misses following place. > > drivers/s390/net/qeth_main.c:2733 > ... > #endif > rxrc = netif_rx(skb); > card->dev->last_rx = jiffies; > card->stats.rx_packets++; > card->stats.rx_bytes += skb->len; > ...
Actually, I found this one as well, but I wasn't sure what to do with it. This one is a bit more complicated because the line with the call to netif_rx is in an else branch if the #ifdef above is taken. So I wasn't sure what would be the best way to solve the problem in this case.
Perhaps the solution would be just to save the value of the len field in a local variable in this case, as you proposed in your original patch.
julia
|  |