Messages in this thread |  | | | From | "Roger Willcocks" <> | | Subject | Re: nfsd bug: create file with specific uid/gid | | Date | Sat, 1 Dec 2007 11:36:18 -0000 |
| |
J. Bruce Fields wrote:
> On Fri, Nov 30, 2007 at 05:06:03PM +0000, Roger Willcocks wrote: >> nfsd/vfs.c:nfsd_create (the v2 version of create) says: >> >> "Set file attributes. Mode has already been set and >> setting uid/gid works only for root" >> >> but it doesn't actually test for root-ness ... > Assignments (especially with things like &=) inside of conditionals > always make my head hurt for some reason. So maybe something like the > below?
The patch looks fine to me, note that nfsd_create_v3 needs fixing too.
> > Thanks for the bug report! (And, by the way, how did you run across > this?) >
I'm working on an NFSp-like server for our clustered file system and my data file creates were not working as expected.
-- Roger
|  |