lkml.org 
[lkml]   [2007]   [Dec]   [1]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    SubjectRe: 2.6.24-rc3-git6: Reported regressions from 2.6.23
    Date
    On Saturday 01 December 2007, Rafael J. Wysocki wrote:

    > Subject : 2.6.24-rc1: pata_amd fails to detect 80-pin wire
    > Submitter : "Thomas Lindroth" <thomas.lindroth@gmail.com>
    > References : http://lkml.org/lkml/2007/11/7/152
    > http://bugzilla.kernel.org/show_bug.cgi?id=9322
    > Handled-By : Tejun Heo <htejun@gmail.com>
    > Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
    > Patch : http://lkml.org/lkml/2007/11/11/115

    Tejun's rework of cable detection code which fixes the problem has
    been just applied into "upstream" (not "upstream-fixes") so it is
    destined for 2.6.25 (I wasn't on cc: BTW) and since I got no feedback
    on my patch (below) which also happens to fix the regression, was
    acked by Alan, tested by Thomas and has been in -mm for 3 weeks now
    I assume that everybody is happy with it (Jeff/Tejun: you were also
    on cc: when the patch was merged into -mm)...

    Linus, please apply.

    [PATCH] pata_amd/pata_via: de-couple programming of PIO/MWDMA and UDMA timings

    * Don't program UDMA timings when programming PIO or MWDMA modes.

    This has also a nice side-effect of fixing regression added by commit
    681c80b5d96076f447e8101ac4325c82d8dce508 ("libata: correct handling of
    SRST reset sequences") (->set_piomode method for PIO0 is called before
    ->cable_detect method which checks UDMA timings to get the cable type).

    * Bump driver version.

    Signed-off-by: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
    Tested-by: "Thomas Lindroth" <thomas.lindroth@gmail.com>
    Acked-by: Alan Cox <alan@lxorguk.ukuu.org.uk>
    Cc: Jeff Garzik <jeff@garzik.org>
    Cc: Tejun Heo <htejun@gmail.com>
    Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
    Signed-off-by: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
    ---
    drivers/ata/pata_amd.c | 5 +++--
    drivers/ata/pata_via.c | 4 ++--
    2 files changed, 5 insertions(+), 4 deletions(-)

    Index: b/drivers/ata/pata_amd.c
    ===================================================================
    --- a/drivers/ata/pata_amd.c
    +++ b/drivers/ata/pata_amd.c
    @@ -25,7 +25,7 @@
    #include <linux/libata.h>

    #define DRV_NAME "pata_amd"
    -#define DRV_VERSION "0.3.9"
    +#define DRV_VERSION "0.3.10"

    /**
    * timing_setup - shared timing computation and load
    @@ -115,7 +115,8 @@ static void timing_setup(struct ata_port
    }

    /* UDMA timing */
    - pci_write_config_byte(pdev, offset + 0x10 + (3 - dn), t);
    + if (at.udma)
    + pci_write_config_byte(pdev, offset + 0x10 + (3 - dn), t);
    }

    /**
    Index: b/drivers/ata/pata_via.c
    ===================================================================
    --- a/drivers/ata/pata_via.c
    +++ b/drivers/ata/pata_via.c
    @@ -63,7 +63,7 @@
    #include <linux/dmi.h>

    #define DRV_NAME "pata_via"
    -#define DRV_VERSION "0.3.2"
    +#define DRV_VERSION "0.3.3"

    /*
    * The following comes directly from Vojtech Pavlik's ide/pci/via82cxxx
    @@ -296,7 +296,7 @@ static void via_do_set_mode(struct ata_p
    }

    /* Set UDMA unless device is not UDMA capable */
    - if (udma_type) {
    + if (udma_type && t.udma) {
    u8 cable80_status;

    /* Get 80-wire cable detection bit */

    \
     
     \ /
      Last update: 2007-12-02 03:43    [W:0.028 / U:60.952 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site