Messages in this thread | | | From | (Eric W. Biederman) | Subject | Re: [PATCH] fix x86-32 early fixmap initialization. | Date | Sat, 01 Dec 2007 19:32:29 -0700 |
| |
"Yinghai Lu" <yhlu.kernel@gmail.com> writes:
> On Dec 1, 2007 5:34 PM, Eric W. Biederman <ebiederm@xmission.com> wrote: >> >> pageexec@freemail.hu writes: >> >> > hello, >> > >> > i've just noticed that the chunk in i386/kernel/head.S ended up in a >> > weird place, namely, it's not going to be executed as it's just after >> > a 'jmp 3f' and before startup_32_smp, probably not what you intended. >> > on a sidenote, the whole thing can be done in a single insn, like: >> > >> > movl $(swapper_pg_pmd - __PAGE_OFFSET + 0x067), (swapper_pg_dir - >> > __PAGE_OFFSET+ 4092) >> > >> > PS: your email address ebiderman@xmisson.com in the commit seems to >> > be wrong as well. >> >> Yes. YH refresh one of my old patches and apparently got my email >> address wrong. >> >> Thanks for the reminder I thought we had fixed this problem a while ago. > > i sent fix to andrew and andi. but it seems they missed it.
Well hopefully the new arch/x86 maintainers can pick up a simple bug fix. Hopefully this code has not bit-rotted yet.
> BTW: how about your head32.c patch series.
I think it is a wonderful idea ;)
Right now I'm buried in the namespace work.
I am seeing my todo list shrink visibly on that day by day, but it is still a mighty list.
Hopefully that list will won't include any patches that just need refreshing and merging by the time 2.6.25 rolls around...
Eric
| |