Messages in this thread | | | Date | Fri, 9 Nov 2007 17:19:24 +0100 | From | Adrian Bunk <> | Subject | Re: Patch tags [was writeout stalls in current -git] |
| |
On Fri, Nov 09, 2007 at 09:10:47AM -0700, Jonathan Corbet wrote: > Adrian Bunk <bunk@kernel.org> wrote: > > > What's missing is a definition which of them are formal tags that must > > be explicitely given (look at point 13 in SubmittingPatches). > > > > Signed-off-by: and Reviewed-by: are the formal tags someone must have > > explicitely given and that correspond to some statement. > > > > OTOH, I can translate a "sounds fine" or "works for me" someone else > > gave me into an Acked-by: resp. Tested-by: tag. > > The discussion of the Cc: tag says: > > This is the only tag which might be added without an explicit > action by the person it names. > > I think that addresses your comment, no? Certainly I wouldn't feel that > I could add any of the other tags to a patch I posted - that's the job > of the person named there.
Acked-by: and Tested-by: do require explicit actions by the person they name, but they are not required to explicitely give this tag.
If a user said "the patch works for me" I would consider it overly bureaucratic to ask the user for a formal tag.
> jon
cu Adrian
--
"Is there not promise of rain?" Ling Tan asked suddenly out of the darkness. There had been need of rain for many days. "Only a promise," Lao Er said. Pearl S. Buck - Dragon Seed
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |