Messages in this thread | | | Date | Thu, 8 Nov 2007 11:03:29 -0800 (PST) | From | Christoph Lameter <> | Subject | Re: [patch 20/23] dentries: Add constructor |
| |
On Thu, 8 Nov 2007, Mel Gorman wrote:
> > Signed-off-by: Christoph Lameter <clameter@sgi.com> > > Seems to be some garbling on there in the signed-off lines.
Yes that needs to be fixed.
> > +void dcache_ctor(struct kmem_cache *s, void *p) > > +{ > > + struct dentry *dentry = p; > > + > > + spin_lock_init(&dentry->d_lock); > > + dentry->d_inode = NULL; > > + INIT_LIST_HEAD(&dentry->d_lru); > > + INIT_LIST_HEAD(&dentry->d_alias); > > +} > > + > > Is there any noticable overhead to the constructor?
Its a minor performance win since we can avoid reinitializing these values and zeroing the object on alloc if there are already allocated objects. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |