lkml.org 
[lkml]   [2007]   [Nov]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [patch 01/28] cpu alloc: The allocator
    On Thu, 8 Nov 2007, Peter Zijlstra wrote:

    > On Tue, 2007-11-06 at 11:51 -0800, Christoph Lameter wrote:
    >
    > > +/*
    > > + * Lock to protect the bitmap and the meta data for the cpu allocator.
    > > + */
    > > +static DEFINE_SPINLOCK(cpu_alloc_map_lock);
    >
    > I thought you got nightmares from global locks :-)

    Yes but this one is rarely taken.

    > Why a bitmap allocator and not a heap allocator?

    Because the allocator must be able to deal with small 4 byte entities.

    > Also, looking at the lock usage, this thing is not IRQ safe, so it
    > should not be called from hardirq context. Please document this.

    Ok.
    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2007-11-08 19:35    [W:0.067 / U:0.232 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site