Messages in this thread | | | Date | Thu, 8 Nov 2007 07:27:23 -0800 | From | Stephane Eranian <> | Subject | Re: [PATCH] fix up perfmon to build on -mm |
| |
Greg,
On Wed, Nov 07, 2007 at 11:53:20AM -0800, Greg KH wrote: > > > Also, a lot of your per-cpu sysfs files should probably move to debugfs > > > as they are for debugging only, right? No need to clutter up sysfs with > > > them when only the very few perfmon developers would be needing access > > > to them. > > > > > Yes, this is mostly debugging. If debugfs is meant for this, then I'll > > be happy to move this stuff over there. Is there some good example of how > > I could do that based on my current sysfs code? > > There is documentation for debugfs in the kernel api document :) > > And, there are many in-kernel users of debugfs, a grep for > "debugfs_create_" should show you some examples of how to use this. If > you have any questions, please let me know.
I have now removed all the perfmon2 statistics from sysfs and moved them to debugfs. I must admit, I like it better this way. Debugfs is also so much easier to program.
Patch has been pushed into my tree. Let me know if you think I can improve the sysfs code some more.
Thanks.
--
-Stephane - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |