lkml.org 
[lkml]   [2007]   [Nov]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: build #337 failed for 2.6.24-rc1-gb1d08ac In function `usbnet_set_settings':
On Wed, Nov 07, 2007 at 06:53:48PM -0800, David Brownell wrote:
> On Wednesday 07 November 2007, Adrian Bunk wrote:
> > On Wed, Nov 07, 2007 at 02:34:52PM -0800, David Brownell wrote:
> > > > > But on the other hand, it seems that only the ASIX code will work
> > > > > right; the DM9601 and MCS7830 Kconfig is different/wrong.
> > > >
> > > > I'm not seeing the problem.
> > > >
> > > > Which configuration will be handled wrongly?
> > >
> > > Notice how only the ASIX kconfig depended on NET_ETHERNET...
> > > since MII depends on NET_ETHERNET, and (last I knew) the
> > > reverse dependencies didn't capture the complete dependency
> > > tree, selecting only MII would leave out some stuff.
> >
> > Except for one s390 net driver (I'll check why it's doing this) the
> > NET_ETHERNET option does not influence what code is being generated -
> > it's just a Kconfig-internal option allowing to disable a huge bunch
> > of drivers at once.
>
> Drivers like ... AX88xxx, DM9601, and MCS7830!! Except as
> it turns out, only the first one behaves as intended.
>
> You can tell it's a problem by the way it's inconsistent,
> regardless of the details of the problem. :)

I'm all for cleanups that make things consistent. :)

As long as we can agree that there's a difference between a problem like
a compile or runtime error and an opportunity for making things
consistent.

> - Dave

cu
Adrian

--

"Is there not promise of rain?" Ling Tan asked suddenly out
of the darkness. There had been need of rain for many days.
"Only a promise," Lao Er said.
Pearl S. Buck - Dragon Seed

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2007-11-08 04:27    [W:0.150 / U:0.460 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site