lkml.org 
[lkml]   [2007]   [Nov]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH] r8169 fix regression on ASUS motherboards
    Francois Romieu wrote:
    > Mark Lord <lkml@rtr.ca> :
    >> Fix r8169 regression on ASUS motherboards.
    >>
    >> The r8169 ethernet driver worked fine in 2.6.23, but fails
    >> in 2.6.24-rc* for the onboard ethernet of ASUS P5B series motherboards.
    >> This patch fixes it again.
    > [...]
    >> --- broken/drivers/net/r8169.c 2007-11-07 12:32:29.000000000 -0500
    >> +++ linux/drivers/net/r8169.c 2007-11-07 12:55:07.000000000 -0500
    >> @@ -1325,6 +1325,7 @@
    >> rtl8169sb_hw_phy_config(ioaddr);
    >> break;
    >> case RTL_GIGA_MAC_VER_11:
    >> + break;
    >> case RTL_GIGA_MAC_VER_12:
    >> case RTL_GIGA_MAC_VER_17:
    >> rtl8168b_hw_phy_config(ioaddr);
    >
    > I am not convinced, the broken ones include some RTL_GIGA_MAC_VER_12
    > too, namely XID = 0x38000000.
    ..

    Tested and working here on VER_11. I don't have a VER_12, so I left that as-is.
    If you want to fix that as well, just move the new "break;" down one line.

    The rest of the broken commit works fine without the new call
    to rtl8168b_hw_phy_config(ioaddr).

    It's been weeks now, so please FIX it now.

    Thanks.





    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2007-11-07 23:25    [W:0.024 / U:31.052 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site