Messages in this thread Patch in this message | | | Subject | Re: [PATCH 1/2] Suppress A.OUT library support in ELF binfmt if !CONFIG_BINFMT_AOUT [try #3] | From | David Woodhouse <> | Date | Wed, 07 Nov 2007 22:07:00 +0000 |
| |
On Wed, 2007-11-07 at 17:43 +0000, David Howells wrote: > --- a/include/linux/a.out.h > +++ b/include/linux/a.out.h > @@ -1,6 +1,11 @@ > #ifndef __A_OUT_GNU_H__ > #define __A_OUT_GNU_H__ > > +#if defined(CONFIG_BINFMT_AOUT) || \ > + defined(CONFIG_BINFMT_AOUT_MODULE) || \ > + defined(CONFIG_IA32_AOUT) || \ > + defined(CONFIG_IA32_AOUT_MODULE) > + > #define __GNU_EXEC_MACROS__ > > #ifndef __STRUCT_EXEC_OVERRIDE__
Ew, no. This is horridly broken. You should never use CONFIG_xxx_MODULE in the static kernel at all -- and you should _especially_ not be using it in header files which are exported to userspace.
This abomination certainly doesn't seem to have any direct relation to mn10300 support -- I think all you really need there is not to attempt to export {asm,linux}/a.out.h if asm/a.out.h doesn't exist, which is something you haven't attempted here anyway.
-- dwmw2
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |