lkml.org 
[lkml]   [2007]   [Nov]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [Unionfs] Re: [PATCH] IGET: Stop UnionFS from using iget() and read_inode()
From
Date
On Wed, 2007-11-07 at 01:44 -0500, Erez Zadok wrote:
> In message <20071106145234.4807.69325.stgit@warthog.procyon.org.uk>, David Howells writes:
> > From: David Howells <dhowells@redhat.com>
> >
> > Stop the UnionFS filesystem from using iget() and read_inode(). Replace
> > unionfs_read_inode() with unionfs_iget(), and call that instead of iget().
> > unionfs_iget() then uses iget_locked() directly and returns a proper error code
> > instead of an inode in the event of an error.
> >
> > unionfs_fill_super() returns any error incurred when getting the root inode
> > instead of EINVAL.
> >
> > Signed-off-by: David Howells <dhowells@redhat.com>
> [...]
>
> Thanks. I tested this code and it passed all my tests. I'll shortly submit
> a slightly revised patch which applies cleanly against the unionfs code in
> -mm.

Does your test set include readahead-list? I can't get it to work with a
union mounted filesystem without segfault'ing and kernel oops'ing.

Paul Albrecht
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2007-11-07 15:33    [W:0.648 / U:0.016 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site