lkml.org 
[lkml]   [2007]   [Nov]   [6]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
DateTue, 6 Nov 2007 02:25:05 -0800
FromAndrew Morton <>
SubjectRe: [PATCH 16/31] IGET: Stop FreeVXFS from using iget() and read_inode() [try #5]
On Thu, 25 Oct 2007 17:35:14 +0100 David Howells <dhowells@redhat.com> wrote:

> Stop the FreeVXFS filesystem from using iget() and read_inode(). Replace
> vxfs_read_inode() with vxfs_iget(), and call that instead of iget().
> vxfs_iget() then uses iget_locked() directly and returns a proper error code
> instead of an inode in the event of an error.
>
> vxfs_fill_super() returns any error incurred when getting the root inode
> instead of EINVAL.

alpha:

fs/freevxfs/vxfs_inode.c:298: error: conflicting types for 'vxfs_iget'
fs/freevxfs/vxfs_extern.h:61: error: previous declaration of 'vxfs_iget' was here

Not completely trivial - the ino_t -> unsigned long conversion needs to be
propagated fairly widely in there.

(when should we be using ino_t and when should we be using unsigned long,
anyway?)
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2007-11-06 11:29    [from the cache]
©2003-2010