Messages in this thread | | | From | Andi Kleen <> | Subject | Re: [PATCH] x86: fix cpu-hotplug regression | Date | Wed, 7 Nov 2007 03:35:43 +0100 |
| |
On Wednesday 07 November 2007 02:12, Andreas Herrmann wrote:
> In cases where not all CPUs are brought up during > boot (e.g. using maxcpus and additional_cpus parameters) > mce_cpu_callback now returns NOTFIY_BAD because > for such CPUs cpu_data is not completely filled when > the notifier is called. Thus mce_create_device fails right > at its beginning: > > if (!mce_available(&cpu_data[cpu])) > return -EIO; > > As a quick fix I suggest to check boot_cpu_data for MCE.
I guess it would be better to just move the device creation to after the CPU has booted. AKA call mce_create_dev() on CPU_ONLINE instead.
-Andi - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |