Messages in this thread | | | Date | Wed, 07 Nov 2007 00:14:48 +0100 | From | Roel Kluin <> | Subject | Re: [PATCH] fix writing to unintended memory in pkt_generic_packet(); drivers/block/pktcdvd.c |
| |
Al Viro wrote: > On Tue, Nov 06, 2007 at 11:43:12PM +0100, Roel Kluin wrote: >> CDROM_PACKET_SIZE is added as an offset to the pointer to unsigned char cmd[16]. >> The adjusted pointer is then used as a destination address in a call to >> memset(). However, when CDROM_PACKET_SIZE is added to the pointer, it is >> automatically scaled by the size of cmd, which is 16. This results in the call >> to memset() writing to unintended memory. > > What are you talking about? rq->cmd is an array, not a pointer to array. > When it occurs as an argument of +, it decays to pointer to array element.
Ok, I misunderstood, but please...
> Please, learn C.
That's not a nice thing to say. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |