Messages in this thread | | | Date | Tue, 6 Nov 2007 10:57:08 -0600 | From | Matt Mackall <> | Subject | Re: [PATCH] Loopback mounts should update the mtime of the underlying file on writes |
| |
On Mon, Nov 05, 2007 at 06:52:41PM -0800, Andrew Morton wrote: > On Mon, 5 Nov 2007 19:09:24 -0600 Matt Mackall <mpm@selenic.com> wrote: > > > Noticed by a Mercurial user. I think this should fix it. > > > > "should". That pitter patter sound your hear is little akpm feet running > away.
Well I did actually test it.
> > Index: l/drivers/block/loop.c > > =================================================================== > > --- l.orig/drivers/block/loop.c 2007-11-05 17:50:07.000000000 -0600 > > +++ l/drivers/block/loop.c 2007-11-05 19:03:51.000000000 -0600 > > @@ -221,6 +221,7 @@ static int do_lo_send_aops(struct loop_d > > offset = pos & ((pgoff_t)PAGE_CACHE_SIZE - 1); > > bv_offs = bvec->bv_offset; > > len = bvec->bv_len; > > + file_update_time(file); > > while (len > 0) { > > sector_t IV; > > unsigned size; > > @@ -299,6 +300,7 @@ static int __do_lo_send_write(struct fil > > > > set_fs(get_ds()); > > bw = file->f_op->write(file, buf, len, &pos); > > + file_update_time(file); > > set_fs(old_fs); > > if (likely(bw == len)) > > return 0; > > Probably makes sense, but bear in mind that we can be fairly deep in > filesystem A functions here, and file_update_time() can do stuff like > starting journal transactions on filesystem B.
I think that can alread happen, no? Especially if we're filling in holes.
-- Mathematics is the supreme nostalgia of our time. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |