Messages in this thread | | | Date | Mon, 05 Nov 2007 16:08:36 +0100 | From | Jiri Slaby <> | Subject | Re: [PATCH] CRISv10 serial driver rewrite take three |
| |
On 11/05/2007 03:31 PM, Jesper Nilsson wrote: > New and improved serial driver for CRISv10, take three, with improvements > suggested by Jiri Slaby. > > - Call wait_event_interruptible with a _correct_ and sensible condition. > - Removed superfluous test of info->flags & ASYNC_CLOSING, since that is done > by wait_event_interruptible. > - Moved common code for deregistering DMA and IRQ to deinit_port function. > - Use setup_timer when initializing flush_timer. > - Convert bit-field for uses_dma_in and uses_dma_out to regular bytes. > - Removed CVS tags. > - Removed defines and comments for CRIS_BUF_SIZE and TTY_THRESHOLD_THROTTLE > (no longer used). > - Cleaned up code to pass checkpatch. > - Add crisv10.h header file. > - Merge of CRISv10 from Axis internal CVS. > > Signed-off-by: Jesper Nilsson <jesper.nilsson@axis.com>
Reviewed-by: Jiri Slaby <jirislaby@gmail.com>
> --- > drivers/serial/crisv10.c | 1293 ++++++++++++------------------------- > drivers/serial/crisv10.h | 146 ++++ > 2 files changed, 580 insertions(+), 859 deletions(-) - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |