Messages in this thread Patch in this message |  | | | Date | Sun, 4 Nov 2007 13:08:36 +0100 (CET) | | From | Stefan Richter <> | | Subject | [PATCH 1/3 2.6.24-rc1-gitX] ieee1394: iso and async streams: s/g list fix |
| |
Date: Sun, 4 Nov 2007 09:44:56 +0100 From: Jens Axboe <jens.axboe@oracle.com>
Torsten Kaiser wrote: > Looking that calltrace upwards, it seems replacing the > memset(dma->sglist,...) with sg_init_table(...) would fix the BUG_ON() > as that inits the SG_MAGIC.
Tested-by: Torsten Kaiser <just.for.lkml@googlemail.com> Signed-off-by: Stefan Richter <stefanr@s5r6.in-berlin.de> --- drivers/ieee1394/dma.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) Index: linux-2.6.24-rc1/drivers/ieee1394/dma.c =================================================================== --- linux-2.6.24-rc1.orig/drivers/ieee1394/dma.c +++ linux-2.6.24-rc1/drivers/ieee1394/dma.c @@ -103,8 +103,7 @@ int dma_region_alloc(struct dma_region * goto err; } - /* just to be safe - this will become unnecessary once sglist->address goes away */ - memset(dma->sglist, 0, dma->n_pages * sizeof(*dma->sglist)); + sg_init_table(dma->sglist, dma->n_pages); /* fill scatter/gather list with pages */ for (i = 0; i < dma->n_pages; i++) { -- Stefan Richter -=====-=-=== =-== --=-- http://arcgraph.de/sr/ - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
|  |