Messages in this thread |  | | | Date | Fri, 30 Nov 2007 18:55:16 +0100 | | From | Adrian Bunk <> | | Subject | Re: m68k build failure |
| |
On Thu, Nov 29, 2007 at 01:19:42PM -0800, Andrew Morton wrote: > On Wed, 28 Nov 2007 09:28:56 +0000 > Al Viro <viro@ftp.linux.org.uk> wrote: > > > On Wed, Nov 28, 2007 at 01:00:56AM -0800, Andrew Morton wrote: > > > > No the slightest. 12 seems like the correct, padded size. A size of 10 is just weird as the unpadded size is 9 bytes. Could you dump the __mod_sdio_device_table section so we can determine if it is cropped or just oddly padded. > > > > > > > > > > err, I'd rather not. I have no shortage of bugs to be going on with here. > > > > > > http://userweb.kernel.org/~akpm/cross-compilers/ has the i386->m68k > > > cross-compiler which I use. > > > > Eh... m68k has 16bit alignment for unsigned long. > > > > diff --git a/include/linux/mod_devicetable.h b/include/linux/mod_devicetable.h > > --- a/include/linux/mod_devicetable.h > > +++ b/include/linux/mod_devicetable.h > > @@ -343,7 +343,8 @@ struct sdio_device_id { > > __u8 class; /* Standard interface or SDIO_ANY_ID */ > > __u16 vendor; /* Vendor or SDIO_ANY_ID */ > > __u16 device; /* Device ID or SDIO_ANY_ID */ > > - kernel_ulong_t driver_data; /* Data private to the driver */ > > + kernel_ulong_t driver_data /* Data private to the driver */ > > + __attribute__((aligned(sizeof(kernel_ulong_t)))); > > }; > > > > /* SSB core, see drivers/ssb/ */ > > That works, but it's a bit obscure. > > sdio_device_id didn't exist in 2.6.23 so we still have time to turn it into > some saner layout. > > Who owns this code, anwyay?
Rusty Russell (Cc'ed)
cu Adrian
--
"Is there not promise of rain?" Ling Tan asked suddenly out of the darkness. There had been need of rain for many days. "Only a promise," Lao Er said. Pearl S. Buck - Dragon Seed
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
|  |