Messages in this thread | | | From | "Rafael J. Wysocki" <> | Subject | Re: [RFC][PATCH 1/3] Suspend: Testing facility | Date | Sat, 3 Nov 2007 19:54:00 +0100 |
| |
Hi,
On Saturday, 3 November 2007 19:23, Pavel Machek wrote: > Hi! > > > Introduce /sys/power/pm_test_level attribute allowing one to test the suspend > > core code. Namely, writing a number (1-5) to this file causes the suspend code > > to work in one of the test modes defined as follows: > > > > 5 - test the freezing of processes > > 4 - test the freezing of processes and suspending of devices > > 3 - test the freezing of processes, suspending of devices and platform global > > control methods > > 2 - test the freezing of processes, suspending of devices, platform global > > control methods and the disabling of nonboot CPUs > > 1 - test the freezing of processes, suspending of devices, platform global > > control methods, the disabling of nonboot CPUs and suspending of > > platform/system devices > > > > Then, if a suspend is started by normal means, the suspend core will perform > > its normal operations up to the point indicated by the test level. Next, it > > will wait for 5 seconds and carry out the resume operations needed to transition > > the system back to the fully functional state. > > > > Writing 0 to /sys/power/pm_test_level turns the testing off. The current test > > level may be read from /sys/power/pm_test_level . > > > > Signed-off-by: Rafael J. Wysocki <rjw@sisk.pl> > > ACK on whole series, but... should we also remove the old debugging > infrastructure? (Or did I just miss it?)
Well, I don't want to remove it just yet, but it's going to be deprecated.
Also, after Johannes' remark I thought it wouldn't be a good idea to export the bare test levels to the user. For this reason I reworked the patches to use strings instead of numbers for the test setting (the attribute is now called "pm_test" and is used in a similar way to "disk").
I'll post the reworked series as soon as I update the changelogs and docs.
Greetings, Rafael - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |