lkml.org 
[lkml]   [2007]   [Nov]   [3]   [last100]   RSS Feed
Views: [more markup]  [less markup]  [headers]  [forward] 
 
Messages in this thread
/
DateSat, 3 Nov 2007 09:31:09 +0100
FromIngo Molnar <>
SubjectRe: delayacct regression in 2.6.24 git
* Balbir Singh <balbir@linux.vnet.ibm.com> wrote:

> >> Am I missing something?
> > 
> > delay accounting was causing context-switch slowdown because it 
> > called sched_clock() explicitly - but indeed my fix to that is wrong 
> > ...
> > 
> > how about reverting the change but also using rq->clock instead of 
> > sched_clock()?
> 
> Hmm... I think that might work, I find that schedule() calls 
> __update_rq_clock() which in turn calls sched_clock(), so it might be 
> a worthwhile optimization.

yep, that's the idea - in general rq->clock is updated for almost every 
scheduling event so you can rely on it instead of calling sched_clock() 
directly.

	Ingo
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2007-11-03 09:33    [from the cache]
©2003-2008