lkml.org 
[lkml]   [2007]   [Nov]   [29]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: 2.6.24-rc3-mm2 (bugfix for memory cgroup per-zone-struct allocation.)
    On Thu, 29 Nov 2007 16:25:33 -0500
    Lee Schermerhorn <Lee.Schermerhorn@hp.com> wrote:
    > > - pn = kmalloc_node(sizeof(*pn), GFP_KERNEL, node);
    > > + /*
    > > + * This routine is called against possible nodes.
    > > + * But it's BUG to call kmalloc() against offline node.
    > > + *
    > > + * TODO: this routine can waste much memory for nodes which will
    > > + * never be onlined. It's better to use memory hotplug callback
    > > + * function.
    > > + */
    > > + if (node_state(node, N_HIGH_MEMORY))
    > > + pn = kmalloc_node(sizeof(*pn), GFP_KERNEL, node);
    > > + else
    > > + pn = kmalloc(sizeof(*pn), GFP_KERNEL);
    > > if (!pn)
    > > return 1;
    > >
    > >
    >
    > This worked for me. Can boot 24-rc3-mm2 [if I turn off async scsi scan,
    > that is--not related to mem controller].
    >
    Thank you !

    > Just FYI, on my ia64 platform, with NODES_SHIFT == 8 [RHEL & SLES ship
    > with 10, I believe], the size of the mem_cgroup structure is ~10KB.
    >
    Yes. But...
    I'll ask Goto-san how memory hotplug callback works and try it.

    Thanks,
    -Kame


    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2007-11-30 01:15    [W:0.020 / U:1.148 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site