Messages in this thread | | | From | Oliver Neukum <> | Subject | Re: Add the infamous Huawei E220 to option.c | Date | Thu, 29 Nov 2007 09:04:28 +0100 |
| |
Am Donnerstag, 29. November 2007 08:52:37 schrieb Pete Zaitcev: > On Thu, 29 Nov 2007 08:38:59 +0100, Oliver Neukum <oliver@neukum.org> wrote: > > Am Donnerstag, 29. November 2007 01:13:05 schrieb Pete Zaitcev: > > > The problem stems from the fact that both option and usb-storage can > > > bind to the modem when in storage mode: the former binds because of the > > > storage class, the latter binds because of VID/PID match. The modprobe > > > loads both, > > > > Isn't it possible to fix this in option's module table? > > At first thought it'll need adding a field to struct usb_serial to save > the driver_info from the ID table in usb_serial_probe. It's something I'd
Why? It is passed to the subdrivers in their probe(). Maybe it should simply be passed in attach(), too?
> like to discuss actually. I hate fields which store information this > way: filled in one place, used in another place... From the perspective > of code prettiness I would rather add another method for usb_serial_probe > to call. But I'm not sure really.
Does the device remain a storage class device after the crucial control message?
Regards Oliver
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |