Messages in this thread | | | From | (Eric W. Biederman) | Subject | Re: [patch -mm 2/4] mqueue namespace : add unshare support | Date | Thu, 29 Nov 2007 08:03:44 -0700 |
| |
Cedric Le Goater <clg@fr.ibm.com> writes:
> From: Cedric Le Goater <clg@fr.ibm.com> > > This patch includes the mqueue namespace in the nsproxy object. It > also adds the support of unshare() and clone() with a new clone flag > CLONE_NEWMQ (1 bit left in the clone flags !) > > CLONE_NEWMQ is required to be cloned or unshared along with CLONE_NEWNS. > This is to make sure that no user mounts of the internal mqueue fs > are left behind when the last task exits.
Sounds reasonable. It would be cool if we didn't have to do this. (Why isn't the mqueue fs not MS_NOUSER?) Ah well.
I'm not certain about requiring CLONE_NEWNS but it looks to be ugly if we try and work it the other way.
> It's totally harmless for the moment because the current code still > uses the default mqueue namespace object 'init_mq_ns'
I don't believe the harmless part. Creating new objects should really come after we have the code to really make them work. In some sense the next patch which makes this work causes ABI breakage. Closely packed together it doesn't matter but...
Eric - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |