Messages in this thread | | | From | David Brownell <> | Subject | Re: [patch/rfc 2.6.24-rc3-mm] gpiolib grows a gpio_desc | Date | Wed, 28 Nov 2007 01:53:38 -0800 |
| |
On Wednesday 28 November 2007, eric miao wrote: > > +static void gpio_ensure_requested(struct gpio_desc *desc) > > { > > - int requested; > > - > > + if (!desc->requested) { > > + desc->requested = 1; > > + pr_warning("GPIO-%ld autorequested\n", gpio_desc - desc); > > produces a warning here about %ld,
It uses "%ld" since I got a warning with "%d". :(
Evidently a cast will be needed.
> and maybe you mean desc - gpio_desc??
Maybe. Either that or the "GPIO-" should be "GPIO"!
> Except for the above, I feel OK overall.
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |