lkml.org 
[lkml]   [2007]   [Nov]   [28]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [ANNOUNCE] Open-FCoE - Fibre Channel over Ethernet Project
I just did a very quick glance over the tree.  Some extremly highlevel
comments to start with before actually starting the source review:


- why do you need your own libcrc? lib/crc32.c has a crc32_le
- libsa should go. Much of it is just wrappers of kernel functions
that should be used directly. Other like that hash, even or state
helpers might either be opencoded in the caller or made completely
generic in lib/. Probably the former but we'll have to see.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2007-11-28 08:47    [W:0.052 / U:0.752 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site