![]() | |||||||||||||
Messages in this thread Patch in this message |
On Nov 27, 2007 10:58 AM, Richard Knutsson <ricknu-0@student.ltu.se> wrote: ... > > + print_hex_dump(KERN_CONT, "", DUMP_PREFIX_OFFSET, > > + 16, 1, > > + buf, len, 0); > > > Not important, but why use '0' instead of 'false'? after read http://lkml.org/lkml/2006/7/27/281, I agreed with you. this is refreshed patch against the lastest cryptodev tree. Cc: Randy Dunlap <randy.dunlap@oracle.com> Signed-off-by: Denis Cheng <crquan@gmail.com> --- crypto/tcrypt.c | 9 ++++----- 1 files changed, 4 insertions(+), 5 deletions(-) diff --git a/crypto/tcrypt.c b/crypto/tcrypt.c index 1e12b86..ae762c2 100644 --- a/crypto/tcrypt.c +++ b/crypto/tcrypt.c @@ -87,12 +87,11 @@ static char *check[] = { "camellia", "seed", "salsa20", NULL }; -static void hexdump(unsigned char *buf, unsigned int len) +static inline void hexdump(unsigned char *buf, unsigned int len) { - while (len--) - printk("%02x", *buf++); - - printk("\n"); + print_hex_dump(KERN_CONT, "", DUMP_PREFIX_OFFSET, + 16, 1, + buf, len, false); } static void tcrypt_complete(struct crypto_async_request *req, int err) -- Denis Cheng - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/ | ||||||||||||
| Last update: 2007-11-27 06:05 [from the cache] ©2003-2008 | |||||||||||||