lkml.org 
[lkml]   [2007]   [Nov]   [26]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH 1/2] crypto test: use print_hex_dump from <linux/kernel.h>
    On Mon, Nov 26, 2007 at 03:13:02PM +0800, Denis Cheng wrote:
    > these utilities implemented in lib/hexdump.c are more handy, please use this.
    >
    > Cc: Randy Dunlap <randy.dunlap@oracle.com>
    > Signed-off-by: Denis Cheng <crquan@gmail.com>

    OK this is pretty nice. But you just missed out because the
    GCM patches that just went in added more hexdump uses :)

    So could you please refresh your patch against the latest cryptodev
    tree? Please also clamp those long lines to 80 characters.

    On an unrelated note, lib/hexdump.c should not print 8-bit text
    even though they pass the is_print test. They just turn up as
    crap on Unicode terminals.

    Thanks,
    --
    Visit Openswan at http://www.openswan.org/
    Email: Herbert Xu ~{PmV>HI~} <herbert@gondor.apana.org.au>
    Home Page: http://gondor.apana.org.au/~herbert/
    PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2007-11-26 15:43    [W:0.047 / U:29.452 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site