Messages in this thread | | | Date | Mon, 26 Nov 2007 19:23:48 +0900 | From | "Joonwoo Park" <> | Subject | Re: [PATCH 4/4] atm/ambassador: kmalloc + memset conversion to kzalloc |
| |
2007/11/26, Robert P. J. Day <rpjday@crashcourse.ca>: > i'm not sure the above is a safe thing to do, as you're zeroing that > area, then making a function call and assuming, upon entry to the > function call, that the caller has done the right thing. i don't see > how you can count on that, depending on who else might want to call > that routine and whether they get sloppy about it. unless you're > prepared to guarantee that there will never be another call to > setup_dev() from elsewhere. >
Thanks for your response. But setup_dev is static function and only amb_init calls it. IMO it's safe.
Thanks. Joonwoo - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |