Messages in this thread | | | Date | Mon, 26 Nov 2007 08:54:04 -0800 | From | Randy Dunlap <> | Subject | Re: [PATCH 2/2] ide-scsi: use print_hex_dump from <linux/kernel.h> |
| |
Matthew Wilcox wrote: > On Mon, Nov 26, 2007 at 04:37:50PM +0800, rae l wrote: >> I know this is different from the original hexdump in ide-scsi.c, I >> just want to tell someone that there's a good implementation of >> hexdump in kernel.h, and I think the default KERN_DEBUG and >> print_hex_dump is more informative and has better output. However, >> anyone want more precise control on debug message could make her/his >> improvements with print_hex_dump. > > using KERN_DEBUG is wrong -- this is part of a line, so you need to use > KERN_NONE or simply "".
s/KERN_NONE/KERN_CONT/ for continuation lines.
-- ~Randy - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |