Messages in this thread | | | Subject | RE: [PATCH 1/2] msi: set 'En' bit of MSI Mapping Capability on HT platform | Date | Mon, 26 Nov 2007 12:01:58 +0800 | From | "Peer Chen" <> |
| |
I think the following lines are suitable for other bridges besides nvidia's, :) : =================== + if (pci_enable_msi_ht_cap(dev) != 0) { + return 0; + } else { + /* Get upstream bridge device handle */ + + bridge_dev = dev->bus->self; + while(bridge_dev != 0) { + if (pci_enable_msi_ht_cap(bridge_dev) != 0) { + return 0; + } else + bridge_dev = bridge_dev->bus->self; + } + + return 1; + }
BRs Peer Chen
-----Original Message----- From: Robert Hancock [mailto:hancockr@shaw.ca] Sent: Monday, November 26, 2007 2:34 AM To: peerchen Cc: linux-kernel; akpm; Peer Chen; Andy Currid Subject: Re: [PATCH 1/2] msi: set 'En' bit of MSI Mapping Capability on HT platform
peerchen wrote: > According to the HyperTransport spec, 'En' indicate if the MSI Mapping is active. So it should be set when enable the MSI. > > The patch base on kernel 2.6.24-rc3 > > Signed-off-by: Andy Currid <acurrid@nvidia.com> > Signed-off-by: Peer Chen <pchen@nvidia.com>
Isn't there a way we can make this work for any upstream HT bridge, rather than only for specific NVIDIA chipsets?
-- Robert Hancock Saskatoon, SK, Canada To email, remove "nospam" from hancockr@nospamshaw.ca Home Page: http://www.roberthancock.com/
----------------------------------------------------------------------------------- This email message is for the sole use of the intended recipient(s) and may contain confidential information. Any unauthorized review, use, disclosure or distribution is prohibited. If you are not the intended recipient, please contact the sender by reply email and destroy all copies of the original message. ----------------------------------------------------------------------------------- - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |