Messages in this thread | | | Date | Mon, 26 Nov 2007 03:59:40 +0100 | From | Richard Knutsson <> | Subject | Re: [PATCH] net/irda/parameters.c: Trivial fixes |
| |
Samuel Ortiz wrote: > Hi Richard, > > On Sat, Nov 24, 2007 at 09:44:05PM +0100, Richard Knutsson wrote: > >> Make a single va_start() -> va_end() path + fixing: >> > Ok, this should be 2 separate patches then. > Thought about it, but they were so simple, I believed they would better be merged... > The warning fixes are all good, but I fail to see the point of the va_end() > one. That doesn't seem to bring any sort of improvement while adding one > variable to the stack and one loop test. Any explanation here ? > Not really. Many seem to like a single return and since this made it one va_end() to every va_start(), I thought it would be appropriate. But if not, then I will only filter this hit out from the va_start()->va_end()-testing and get going. > I'll push the warning fix for now, thanks. > Alright, thank you. > Cheers, > Samuel. > > cu Richard Knutsson
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |