lkml.org 
[lkml]   [2007]   [Nov]   [21]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH RFC] [5/9] modpost: Fix a buffer overflow in modpost
    Date

    When passing an file name > 1k the stack could be overflowed.
    Not really a security issue, but still better plugged.


    ---
    scripts/mod/modpost.c | 3 ++-
    1 file changed, 2 insertions(+), 1 deletion(-)

    Index: linux/scripts/mod/modpost.c
    ===================================================================
    --- linux.orig/scripts/mod/modpost.c
    +++ linux/scripts/mod/modpost.c
    @@ -1656,7 +1656,6 @@ int main(int argc, char **argv)
    {
    struct module *mod;
    struct buffer buf = { };
    - char fname[SZ];
    char *kernel_read = NULL, *module_read = NULL;
    char *dump_write = NULL;
    int opt;
    @@ -1709,6 +1708,8 @@ int main(int argc, char **argv)
    err = 0;

    for (mod = modules; mod; mod = mod->next) {
    + char fname[strlen(mod->name) + 10];
    +
    if (mod->skip)
    continue;

    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/
    \
     
     \ /
      Last update: 2007-11-22 03:47    [W:4.083 / U:0.132 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site