lkml.org 
[lkml]   [2007]   [Nov]   [20]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [rfc 18/45] cpu alloc: XFS counters
    On Tue, Nov 20, 2007 at 12:38:29PM -0800, Christoph Lameter wrote:
    > On Tue, 20 Nov 2007, Christoph Hellwig wrote:
    >
    > > On Mon, Nov 19, 2007 at 05:11:50PM -0800, clameter@sgi.com wrote:
    > > > Also remove the useless zeroing after allocation. Allocpercpu already
    > > > zeroed the objects.
    > >
    > > You still haven't answered my comment to the last iteration.
    >
    > And you have not read the discussion on that subject in the prior
    > iteration between Peter Zilkstra and me.

    Seeing as I didn't notice this patchest changed XFS (where's the cc?)
    until I saw hch's question I'd appreciate a pointer to that discussion
    as it's long been deleted from my mailbox.

    FWIW, I happen to agree with Christoph (hch) that the shouting
    macros are an ugly step backwards, esp. given that is replacing:

    #define per_cpu_ptr(ptr, cpu) percpu_ptr((ptr), (cpu))

    a set of lowercase macros....

    Cheers,

    Dave.
    --
    Dave Chinner
    Principal Engineer
    SGI Australian Software Group
    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2007-11-21 05:51    [W:0.019 / U:66.036 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site