Messages in this thread | | | Subject | Re: [patch] 0/4 Support for Toshiba TMIO multifunction devices | From | ian <> | Date | Wed, 21 Nov 2007 03:54:15 +0000 |
| |
On Wed, 2007-11-21 at 10:23 +0800, eric miao wrote: > Roughly went through the patch, looks good, here comes the remind, though :-) > > 1. is it possible to use some name other than "soc_core", maybe > "tmio_core" so that other multifunction chips sharing a core base > will live easier.
It's (soc-core) not tmio MFD specific - its already used by other MFD chips (although obviously not ones in mainline (yet!)
it might be better named 'mfd-core' though, as thats its intended use...
> 2. those C++ style comments "//" are not so pleasant...
Should I clean them up and resubmit?
More to the point, who should I be submitting them to? the files under arm/ are obviously for RMK to peruse, but I couldnt find an entry for drivers/mfd in MAINTAINERS...
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |