Messages in this thread | | | Date | Tue, 20 Nov 2007 12:36:57 -0800 (PST) | From | Christoph Lameter <> | Subject | Re: [rfc 03/45] Generic CPU operations: Core piece |
| |
On Mon, 19 Nov 2007, Mathieu Desnoyers wrote:
> > But (x) is returned to the "caller" of the macro so it should be specially > > marged. > > > > I don't think that it really matters.. the preprocessor already wraps > all the ({ }) in a single statement, doesn't it ?
No it does not matter for the preprocessor. It matters for readability because I want to see that this is the return value.
> Since checkpatch.pl emits a warning when a one liner if() uses brackets, > I guess compactness of code is preferred to a consistent style.
I wish someone would fix it. Its giving so much false positives that its useless for me. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |