lkml.org 
[lkml]   [2007]   [Nov]   [2]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: build #337 failed for 2.6.24-rc1-gb1d08ac In function `usbnet_set_settings':
    On Fri, Nov 02, 2007 at 11:45:15AM -0700, David Brownell wrote:
    > On Thursday 01 November 2007, Adrian Bunk wrote:
    > > The following combination of options is simply an unusual one:
    > >
    > > CONFIG_MII=m
    > > CONFIG_USB_USBNET=y
    > > CONFIG_USB_USBNET_MII=n
    >
    > I though that had been fixed for ages ...
    >
    > This should do a better job of it.
    >
    > - Dave
    >
    > ========== CUT HERE
    > Simplify handling of the MII-dependent usbnet based adapters: stick
    > to forward dependencies, and explicitly handle the core dependency.
    >
    > Signed-off-by: David Brownell <dbrownell@users.sourceforge.net>
    > ---
    > drivers/net/usb/Kconfig | 23 ++++++++++++-----------
    > drivers/net/usb/usbnet.c | 9 ++++++++-
    > 2 files changed, 20 insertions(+), 12 deletions(-)
    >
    > --- a.orig/drivers/net/usb/Kconfig 2007-10-21 10:35:16.000000000 -0700
    > +++ a/drivers/net/usb/Kconfig 2007-11-02 11:32:15.000000000 -0700
    > @@ -93,13 +93,8 @@ config USB_RTL8150
    > To compile this driver as a module, choose M here: the
    > module will be called rtl8150.
    >
    > -config USB_USBNET_MII
    > - tristate
    > - default n
    > -
    > config USB_USBNET
    > tristate "Multi-purpose USB Networking Framework"
    > - select MII if USB_USBNET_MII != n
    > ---help---
    > This driver supports several kinds of network links over USB,
    > with "minidrivers" built around a common network driver core
    > @@ -131,11 +126,19 @@ config USB_USBNET
    > To compile this driver as a module, choose M here: the
    > module will be called usbnet.
    >
    > +# usbnet core will support MII when MII is static, or both are modules
    > +config USB_NET_MII
    > + tristate
    > + depends on USB_USBNET && NET_ETHERNET && (MII = y || MII = USB_USBNET)
    > + default MII
    > +
    > +comment "MII support is needed for most Ethernet adapters"
    > + depends on USB_USBNET && USB_NET_MII=n
    >...

    This approach has two disadvantages:
    - it's complicated
    - the MII stuff is an implementation detail, and we shouldn't bother
    the user with it (especially since we can do better)

    If you want to keep the #ifdef's, what's the problem with the second
    patch I proposed to fix this bug?

    cu
    Adrian

    --

    "Is there not promise of rain?" Ling Tan asked suddenly out
    of the darkness. There had been need of rain for many days.
    "Only a promise," Lao Er said.
    Pearl S. Buck - Dragon Seed

    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2007-11-02 20:01    [W:0.023 / U:62.412 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site