[lkml]   [2007]   [Nov]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
    Subject[CIFS] still incorrect cifs_reconnect fix?

    while merging commits f01d5e14e764b14b6bf5512678523d009254b209 and
    638b250766272fcaaa0f7ed2776f58f4ac701914 into SLES10, I've noticed that
    there's apparently a bug. The code currently looks like this:

    pdu_length = 4; /* enough to get RFC1001 header */
    length =
    kernel_recvmsg(csocket, &smb_msg,
    &iov, 1, pdu_length, 0 /* BB other flags? */);

    /* ... some irrelevant code left out ... */

    } else if (length < 4) { /* <----- HERE IS THE PROBLEM
    cFYI(1, ("less than four bytes received (%d bytes)",
    pdu_length -= length;
    goto incomplete_rcv;

    I think we should be checking for length < pdu_length, not for length <
    4, because if we read 2 bytes in the first run and 2 bytes in the second
    un, CIFS will still treat the second run as incomplete (and possibly run
    in an infinite loop). Am I missing something obvious?

    Kind regards,
    Petr Tesarik

    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to
    More majordomo info at
    Please read the FAQ at

     \ /
      Last update: 2007-11-19 10:33    [W:0.019 / U:122.212 seconds]
    ©2003-2017 Jasper Spaans. hosted at Digital OceanAdvertise on this site