lkml.org 
[lkml]   [2007]   [Nov]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH 0/4, v3] Physical PCI slot objects
    On Sat, Nov 17, 2007 at 11:29:54AM -0700, Alex Chiang wrote:
    > Hi all,
    >
    > This is v3 of the pci_slot patch series.
    >
    > The major change is making the ACPI-PCI slot driver a Kconfig
    > option, as per the recommendations of others (Gary, Kenji-san).

    Alex, What I was trying to suggest is a boot-time kernel option,
    not a kernel configuration option. The basic idea is to give
    the user (with a single binary kernel) the ability to include
    your ACPI-PCI slot driver feature changes only when they are
    really needed. In addition to reducing the number of
    system/PCI hotplug driver combinations where your changes
    would need to be validated, I believe would also help
    alleviate other worries (e.g. Andi Kleen's memory consumption
    concern). I believe this goal could also be achieved with the
    kernel config option by making the pci_slot module runtime
    loadable with the PCI hotplug drivers only visiting your new
    code when the pci_slot driver is loaded, although I think this
    would be more difficult to implement.

    Also, I notice that even with your current CONFIG_ACPI_PCI_SLOT
    implementation your numerous PCI hotplug driver changes (except
    for only two places in pci_hotplug_core.c where there is
    `#ifndef CONFIG_ACPI_PCI_SLOT` and `#ifdef CONFIG_ACPI_PCI_SLOT`)
    are _always_ exposed. So, even with CONFIG_ACPI_PCI_SLOT disabled
    there is IMO a need for testing of the affected PCI hotplug drivers
    on more than a small number of isolated systems.

    The good news is that I was able to test your v3 changes
    (w/2.6.24-rc3 source) on our x3850 today with 'acpiphp'
    and, except for the above mentioned inability to run-time
    include/exclude them, they seemed to work fine. The previous
    boot-time ACPI error messages are gone and I was able to
    successfully hot-remove and hot-add both PCI-X and PCIe
    adapters.

    Thanks,
    Gary

    --
    Gary Hade
    System x Enablement
    IBM Linux Technology Center
    503-578-4503 IBM T/L: 775-4503
    garyhade@us.ibm.com
    http://www.ibm.com/linux/ltc


    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2007-11-20 00:35    [W:0.022 / U:1.352 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site