| Date | Mon, 19 Nov 2007 23:21:51 +0100 | From | Bastian Blank <> | Subject | Re: [PATCH 7/24] consolidate msr.h |
| |
On Fri, Nov 09, 2007 at 04:42:48PM -0200, Glauber de Oliveira Costa wrote: > - wrmsrl(MSR_CSTAR, ia32_cstar_target); > + wrmsrl(MSR_CSTAR, (u64)ia32_cstar_target);
Hmm, why do you add explicit casts? The compiler should convert that correctly on its own.
> +static inline void wrmsrl(unsigned int msr, unsigned long long val)
Hmm, long long is 64 bit on all x86, but why not use explicit u64 to show that?
Bastian
-- Captain's Log, star date 21:34.5... - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
|