[lkml]   [2007]   [Nov]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
    SubjectRe: [PATCH 7/24] consolidate msr.h
    On Fri, Nov 09, 2007 at 04:42:48PM -0200, Glauber de Oliveira Costa wrote:
    > - wrmsrl(MSR_CSTAR, ia32_cstar_target);
    > + wrmsrl(MSR_CSTAR, (u64)ia32_cstar_target);

    Hmm, why do you add explicit casts? The compiler should convert that
    correctly on its own.

    > +static inline void wrmsrl(unsigned int msr, unsigned long long val)

    Hmm, long long is 64 bit on all x86, but why not use explicit u64 to
    show that?


    Captain's Log, star date 21:34.5...
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to
    More majordomo info at
    Please read the FAQ at

     \ /
      Last update: 2007-11-19 23:25    [W:0.020 / U:73.704 seconds]
    ©2003-2017 Jasper Spaans. hosted at Digital OceanAdvertise on this site