[lkml]   [2007]   [Nov]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
    SubjectRe: [PATCHv3 0/4] sys_indirect system call
    Hash: SHA1

    Eric Dumazet wrote:
    >> union indirect_params i;
    >> i.file_flags.flags = O_CLOEXEC;
    > This setup forbids future addons to file_flags
    > In three years, when we want to add a new indirect feature to socket()
    > call, do we need a new indirect2() syscall ?

    No, it doesn't. The setup is indefinitely expandable.

    All you need to do, if it becomes necessary to have more than an int, is
    to define a little structure for the system call and then use it. The
    only requirement is that the code has to assume a value of zero is what
    is used today. That's the whole point.

    union indirect_params {
    struct {
    int flags;
    } file_flags;
    struct {
    int flags;
    int new_syscall_data1;
    sigset_t and_a_sigmask;
    } new_data;

    Old programs will set only the 'flags' member of 'new_data' while new
    once can also set the new elements. New programs on old kernels will
    eithe have failing calls since the structure is too big or the call will
    not have all the desired effects. The latter can be tested for.

    > Or better, you could avoid using 'union indirect_params' in user code, and
    > only use the substructs for each function.

    There is no overhead introduced through the union. The only reason the
    union is there in the first place is to allocate sufficient data in
    task_struct to cover all cases.

    - --
    ➧ Ulrich Drepper ➧ Red Hat, Inc. ➧ 444 Castro St ➧ Mountain View, CA ❖
    Version: GnuPG v1.4.7 (GNU/Linux)

    -----END PGP SIGNATURE-----
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to
    More majordomo info at
    Please read the FAQ at

     \ /
      Last update: 2007-11-19 16:15    [W:0.021 / U:121.896 seconds]
    ©2003-2017 Jasper Spaans. hosted at Digital OceanAdvertise on this site