lkml.org 
[lkml]   [2007]   [Nov]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH] kconfig: use $K64BIT to set 64BIT with all*config targets
    Hi,

    On Fri, 16 Nov 2007, Sam Ravnborg wrote:

    > 1) make all*config, randconfig, defconfig is broken on 64-bit boxes

    With your approach you made it impossible to set 64BIT from all*.config,
    which is the proper way to set the defaults.

    > 2) A pure code refactoring patch is reverted for no obvious reason

    It was done for the wrong reasons, otherwise the warning before it should
    have been included as well and then the function could have been reused
    for the "# ... is not set" case as well.

    > 3) Behavioral changes are not documented:
    > - 32-bit/64-bit can only be selected in config is you specify ARCH=x86

    Which is now the default and thus it behaves more like other archs.

    > - ARCH= takes precedence over kernel config for a configured kernel

    What point is there in being able to specify ARCH=x86_64 and then still
    produce a 32bit kernel?

    > 4) The changelogs miss title on reverted patches

    Seriously?

    bye, Roman
    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2007-11-16 13:57    [W:0.019 / U:27.844 seconds]
    ©2003-2017 Jasper Spaans. hosted at Digital OceanAdvertise on this site