Messages in this thread | | | Date | Thu, 15 Nov 2007 10:40:15 -0700 | From | Alex Chiang <> | Subject | Re: [PATCH 2/5] Construct one fakephp slot per pci slot |
| |
* Rolf Eike Beer <eike-hotplug@sf-tec.de>: > Am Mittwoch, 14. November 2007 schrieb Alex Chiang: > > * Matthew Wilcox <matthew@wil.cx>: > > > On Wed, Nov 14, 2007 at 12:37:29PM -0700, Alex Chiang > > > > Register one slot per slot, rather than one slot per > > > > function. Change the name of the slot to fake%d instead > > > > of the pci address. > > > > > > > > +#define SLOT_NAME_SIZE KOBJ_NAME_LEN > > > > > > Defined, then never used ... how about s/KOBJ_NAME_LEN/8/, > > > then use SLOT_NAME_SIZE throughout? > > > > Whoops, good catch. I had a braino there. > > Just drop it and use sizeof(dslot->name) in snprintf(). Just be > careful not to use slot->name there as it would always be > sizeof(void*)!
Thanks, even better.
/ac
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |