lkml.org 
[lkml]   [2007]   [Nov]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Date
    From
    Subject[patch 19/40] MSI: Use correct data offset for 32-bit MSI in read_msi_msg()


    -stable review patch. If anyone has any objections, please let us know.

    ------------------
    From: Roland Dreier <roland@digitalvampire.org>

    patch cbf5d9e6b9bcf03291cbb51db144b3e2773a8a2d in mainline.

    While reading the MSI code trying to find a reason why MSI wouldn't
    work for devices that have a 32-bit MSI address capability, I noticed
    that read_msi_msg() seems to read the message data from the wrong
    offset in this case.

    Signed-off-by: Roland Dreier <roland@digitalvampire.org>
    Acked-by: Eric W. Biederman <ebiederm@xmission.com>
    Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>

    ---
    drivers/pci/msi.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    --- a/drivers/pci/msi.c
    +++ b/drivers/pci/msi.c
    @@ -132,7 +132,7 @@ void read_msi_msg(unsigned int irq, stru
    pci_read_config_word(dev, msi_data_reg(pos, 1), &data);
    } else {
    msg->address_hi = 0;
    - pci_read_config_word(dev, msi_data_reg(pos, 1), &data);
    + pci_read_config_word(dev, msi_data_reg(pos, 0), &data);
    }
    msg->data = data;
    break;
    --
    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2007-11-15 08:03    [W:0.032 / U:0.752 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site