lkml.org 
[lkml]   [2007]   [Nov]   [14]   [last100]   RSS Feed
Views: [more markup]  [less markup]  [headers]  [forward] 
 
Messages in this thread
/
DateWed, 14 Nov 2007 07:09:40 +0100 (CET)
FromJulia Lawall <>
SubjectRe: [PATCH 1/4] drivers/i2c: Drop redundant includes of moduleparam.h
>> From: Julia Lawall <julia@diku.dk>
>>
>> Drop #include <linux/moduleparam.h> in files that also include #include
>> <linux/module.h>.  module.h includes moduleparam.h already.
>
> i'm not convinced that's a good idea.  while module.h does currently
> (and unfortunately) include moduleparam.h, there may come a day when
> those header files are refactored to actually make sense, at which
> point all those missing moduleparam.h inclusions will cause all sorts
> of bad things to happen.

They were removed from the drivers/media files in August:
9c12224a607a4b22ab86784e3394b52810b9507c
Perhaps they should be put back there then?

julia

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2007-11-14 07:11    [from the cache]
©2003-2008