lkml.org 
[lkml]   [2007]   [Nov]   [14]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: 2.6.24-rc2-mm1
Andrew Morton wrote:
[cut]
> hm, that was supposed to shut itself off after 100 messages:
>
> if (unlikely(clone_flags & (CLONE_DETACHED|CLONE_STOPPED))) {
> static int __read_mostly count = 100;
>
> if (count && printk_ratelimit()) {
> char comm[TASK_COMM_LEN];
>
> count--;
> printk(KERN_INFO "fork(): process `%s' used deprecated "
> "clone flags 0x%lx\n",
> get_task_comm(comm, current),
> clone_flags & (CLONE_DETACHED|CLONE_STOPPED));
> }
> }
>
> I don't see how you got 151 instances. I guess I'm having another stupid
> day.

It looks like a simple race, two threads do count-- before doing
if(count), resulting in an almost infinite loop. Probably.

atomic_test_and_dec might work.







-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2007-11-14 07:09    [W:0.156 / U:0.052 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site