Messages in this thread | | | Date | Tue, 13 Nov 2007 17:46:40 -0600 | From | Scott Wood <> | Subject | Re: [PATCH] powerpc: Add support for PORTA and PORTB odr registers |
| |
Jochen Friedrich wrote: > @@ -474,6 +481,12 @@ static void cpm1_set_pin16(int port, int pin, int > flags) > else > clrbits16(&iop->par, pin); > > + if (port == CPM_PORTA) { > + if (flags & CPM_PIN_OPENDRAIN) > + setbits16(&iop->odr, pin); > + else > + clrbits16(&iop->odr, pin); > + } > if (port == CPM_PORTC) { > if (flags & CPM_PIN_SECONDARY) > setbits16(&iop->sor, pin);
Where is the odr field of cpm_ioport16 defined? It's the same position as sor, so maybe call it odr_sor or something.
Also, please add an extra newline after the closing brace.
-Scott - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |