lkml.org 
[lkml]   [2007]   [Nov]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH 0/5][RFC] Physical PCI slot objects
    On Tue, Nov 13, 2007 at 01:11:02PM -0700, Matthew Wilcox wrote:
    > On Tue, Nov 13, 2007 at 10:51:22AM -0800, Greg KH wrote:
    > > Ok, again, I want to see the IBM people sign off on this, after testing
    > > on all of their machines, before I'll consider this, as I know the IBM
    > > acpi tables are "odd".
    >
    > That seems a little higher standard than patches are normally held to.
    > How about the patches get sent to the appropriate people at IBM (who are
    > they?)

    I be one of them. :) I have been involved in many (but not all)
    of IBM's x86 based (IBM System x) servers with hotplug capable
    PCI slots. I have mostly worked on 'acpiphp' associated issues.

    > and if we haven't heard a NAK from them after a month, then they
    > get applied?

    I am not fundamentally opposed to this new capability but
    share the same concerns that Greg and others have expressed.
    So far, I have only tried the changes on one single node
    system (IBM x3850) but the below NAK-worthy result supports
    the idea that the changes need to be well and widely tested.

    Have you possibly considered a kernel option as a kinder and
    gentler way of introducing the changes?

    Gary

    --
    Gary Hade
    System x Enablement
    IBM Linux Technology Center
    503-578-4503 IBM T/L: 775-4503
    garyhade@us.ibm.com
    http://www.ibm.com/linux/ltc

    ====
    IBM x3850
    Slots 1-2: PCI-X under PCI root bridges
    Slots 3-6: PCIe under transparent P2P bridges
    Slot 1: PCI-X - populated
    Slot 2: PCI-X - !populated
    Slot 3: PCIe - populated
    Slot 4: PCIe - !populated
    Slot 5: PCIe - !populated
    Slot 6: PCIe - populated

    result is with 2.6.24-rc2 plus all 4 proposed patches
    problem: acpiphp failed to register empty PCIe slots 4 and 5
    ====

    # dmesg
    acpiphp: ACPI Hot Plug PCI Controller Driver version: 0.5
    acpiphp_glue: found PCI host-bus bridge with hot-pluggable slots
    acpiphp_glue: found ACPI PCI Hotplug slot 1 at PCI 0000:02:01
    acpiphp: Slot [1] registered
    acpiphp_glue: found PCI host-bus bridge with hot-pluggable slots
    acpiphp_glue: found ACPI PCI Hotplug slot 2 at PCI 0000:06:01
    acpiphp: Slot [2] registered
    acpiphp_glue: found PCI-to-PCI bridge at PCI 0000:0a:00.0
    acpiphp_glue: found ACPI PCI Hotplug slot 3 at PCI 0000:0b:00
    acpiphp: Slot [3] registered
    acpiphp_glue: found PCI-to-PCI bridge at PCI 0000:0f:00.0
    acpiphp_glue: found ACPI PCI Hotplug slot 4 at PCI 0000:10:00
    acpiphp: pci_hp_register failed with error -17
    acpiphp_glue: acpiphp_register_hotplug_slot failed(err code = 0xffffffef)
    acpiphp_glue: found ACPI PCI Hotplug slot 4 at PCI 0000:10:00
    acpiphp: pci_hp_register failed with error -17
    acpiphp_glue: acpiphp_register_hotplug_slot failed(err code = 0xffffffef)
    acpiphp_glue: found ACPI PCI Hotplug slot 4 at PCI 0000:10:00
    acpiphp: pci_hp_register failed with error -17
    acpiphp_glue: acpiphp_register_hotplug_slot failed(err code = 0xffffffef)
    acpiphp_glue: found ACPI PCI Hotplug slot 4 at PCI 0000:10:00
    acpiphp: pci_hp_register failed with error -17
    acpiphp_glue: acpiphp_register_hotplug_slot failed(err code = 0xffffffef)
    acpiphp_glue: found ACPI PCI Hotplug slot 4 at PCI 0000:10:00
    acpiphp: pci_hp_register failed with error -17
    acpiphp_glue: acpiphp_register_hotplug_slot failed(err code = 0xffffffef)
    acpiphp_glue: found ACPI PCI Hotplug slot 4 at PCI 0000:10:00
    acpiphp: pci_hp_register failed with error -17
    acpiphp_glue: acpiphp_register_hotplug_slot failed(err code = 0xffffffef)
    acpiphp_glue: found ACPI PCI Hotplug slot 4 at PCI 0000:10:00
    acpiphp: pci_hp_register failed with error -17
    acpiphp_glue: acpiphp_register_hotplug_slot failed(err code = 0xffffffef)
    acpiphp_glue: found ACPI PCI Hotplug slot 4 at PCI 0000:10:00
    acpiphp: pci_hp_register failed with error -17
    acpiphp_glue: acpiphp_register_hotplug_slot failed(err code = 0xffffffef)
    acpiphp_glue: found PCI-to-PCI bridge at PCI 0000:14:00.0
    acpiphp_glue: found ACPI PCI Hotplug slot 5 at PCI 0000:15:00
    acpiphp: pci_hp_register failed with error -17
    acpiphp_glue: acpiphp_register_hotplug_slot failed(err code = 0xffffffef)
    acpiphp_glue: found ACPI PCI Hotplug slot 5 at PCI 0000:15:00
    acpiphp: pci_hp_register failed with error -17
    acpiphp_glue: acpiphp_register_hotplug_slot failed(err code = 0xffffffef)
    acpiphp_glue: found ACPI PCI Hotplug slot 5 at PCI 0000:15:00
    acpiphp: pci_hp_register failed with error -17
    acpiphp_glue: acpiphp_register_hotplug_slot failed(err code = 0xffffffef)
    acpiphp_glue: found ACPI PCI Hotplug slot 5 at PCI 0000:15:00
    acpiphp: pci_hp_register failed with error -17
    acpiphp_glue: acpiphp_register_hotplug_slot failed(err code = 0xffffffef)
    acpiphp_glue: found ACPI PCI Hotplug slot 5 at PCI 0000:15:00
    acpiphp: pci_hp_register failed with error -17
    acpiphp_glue: acpiphp_register_hotplug_slot failed(err code = 0xffffffef)
    acpiphp_glue: found ACPI PCI Hotplug slot 5 at PCI 0000:15:00
    acpiphp: pci_hp_register failed with error -17
    acpiphp_glue: acpiphp_register_hotplug_slot failed(err code = 0xffffffef)
    acpiphp_glue: found ACPI PCI Hotplug slot 5 at PCI 0000:15:00
    acpiphp: pci_hp_register failed with error -17
    acpiphp_glue: acpiphp_register_hotplug_slot failed(err code = 0xffffffef)
    acpiphp_glue: found ACPI PCI Hotplug slot 5 at PCI 0000:15:00
    acpiphp: pci_hp_register failed with error -17
    acpiphp_glue: acpiphp_register_hotplug_slot failed(err code = 0xffffffef)
    acpiphp_glue: found PCI-to-PCI bridge at PCI 0000:19:00.0
    acpiphp_glue: found ACPI PCI Hotplug slot 6 at PCI 0000:1a:00
    acpiphp: Slot [6] registered
    acpiphp_glue: Bus 0000:1a has 1 slot
    acpiphp_glue: Bus 0000:15 has 0 slots
    acpiphp_glue: Bus 0000:10 has 0 slots
    acpiphp_glue: Bus 0000:0b has 1 slot
    acpiphp_glue: Bus 0000:06 has 1 slot
    acpiphp_glue: Bus 0000:02 has 1 slot
    acpiphp_glue: Total 4 slots

    # find /sys/bus/pci/slots
    /sys/bus/pci/slots
    /sys/bus/pci/slots/1
    /sys/bus/pci/slots/1/address
    /sys/bus/pci/slots/1/power
    /sys/bus/pci/slots/1/attention
    /sys/bus/pci/slots/1/latch
    /sys/bus/pci/slots/1/adapter
    /sys/bus/pci/slots/2
    /sys/bus/pci/slots/2/address
    /sys/bus/pci/slots/2/power
    /sys/bus/pci/slots/2/attention
    /sys/bus/pci/slots/2/latch
    /sys/bus/pci/slots/2/adapter
    /sys/bus/pci/slots/3
    /sys/bus/pci/slots/3/address
    /sys/bus/pci/slots/3/power
    /sys/bus/pci/slots/3/attention
    /sys/bus/pci/slots/3/latch
    /sys/bus/pci/slots/3/adapter
    /sys/bus/pci/slots/4
    /sys/bus/pci/slots/4/address
    /sys/bus/pci/slots/5
    /sys/bus/pci/slots/5/address
    /sys/bus/pci/slots/6
    /sys/bus/pci/slots/6/address
    /sys/bus/pci/slots/6/power
    /sys/bus/pci/slots/6/attention
    /sys/bus/pci/slots/6/latch
    /sys/bus/pci/slots/6/adapter

    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2007-11-14 00:11    [W:0.030 / U:30.900 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site