Messages in this thread Patch in this message | | | Date | Tue, 13 Nov 2007 12:21:16 -0800 | From | Jeremy Fitzhardinge <> | Subject | [PATCH] x86/paravirt: revert exports to restore old behaviour |
| |
Subject: x86/paravirt: revert exports to restore old behaviour
Subdividing the paravirt_ops structure caused a regression in certain non-GPL modules which try to use mmu_ops and cpu_ops. This restores the old behaviour, and makes it consistent with the non-CONFIG_PARAVIRT case.
Tobias's mail: > commit to .24 tree: > http://git.kernel.org/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commit;h=93b1eab3d29e7ea32ee583de3362da84db06ded8 > > introduces: > +EXPORT_SYMBOL_GPL(pv_mmu_ops); > +EXPORT_SYMBOL_GPL(pv_cpu_ops); > > pv_cpu_ops is for nvidia > pv_mmu_ops' is for amd(ati) > > which will break 32bit systems with paravirt enabled and trying to compile > the binary graphic drivers from amd(ati) and nvidia.
[ Tobias: It would be nice to know exactly which operations the modules you're trying to compile are using. ]
Signed-off-by: Jeremy Fitzhardinge <Jeremy.Fitzhardinge@citrix.com> Cc: Tobias Powalowski <t.powa@gmx.de> Cc: Zach Amsden <zach@vmware.com>
--- arch/x86/kernel/paravirt.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
=================================================================== --- a/arch/x86/kernel/paravirt.c +++ b/arch/x86/kernel/paravirt.c @@ -440,8 +440,8 @@ struct pv_mmu_ops pv_mmu_ops = { }; EXPORT_SYMBOL_GPL(pv_time_ops); -EXPORT_SYMBOL_GPL(pv_cpu_ops); -EXPORT_SYMBOL_GPL(pv_mmu_ops); +EXPORT_SYMBOL (pv_cpu_ops); +EXPORT_SYMBOL (pv_mmu_ops); EXPORT_SYMBOL_GPL(pv_apic_ops); EXPORT_SYMBOL_GPL(pv_info); EXPORT_SYMBOL (pv_irq_ops); - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |