lkml.org 
[lkml]   [2007]   [Nov]   [13]   [last100]   RSS Feed
Views: [more markup]  [less markup]  [headers]  [forward] 
 
Messages in this thread
    /
    DateMon, 12 Nov 2007 23:59:10 -0800
    FromAndrew Morton <>
    SubjectRe: [PATCH] Introduce ext4_find_next_bit
    On Fri, 21 Sep 2007 10:55:05 +0530 "Aneesh Kumar K.V" <aneesh.kumar@linux.vnet.ibm.com> wrote:
    
    > Also add generic_find_next_le_bit
    > 
    > This gets used by the ext4 multi block allocator patches.
    > 
    
    arm allmodconfig:
    
    fs/ext4/mballoc.c: In function `ext4_mb_generate_buddy':
    fs/ext4/mballoc.c:836: error: implicit declaration of function `ext2_find_next_bit'
    
    This patch makes my head spin.
    
    Why did we declare generic_find_next_le_bit() in
    include/asm-powerpc/bitops.h (wrong) as well as in
    include/asm-generic/bitops/le.h (presumably correct)?
    
    Why is it touching a powerpc file and no any other architectures? 
    Something screwed up in powerpc land?
    
    And why did arm break?
    
    Shudder.  Anyway, please fix, and if that fix requires that various
    braindamaged be repaired, please repair the braindamage rather than going
    along with it.
    
    Thanks.
    
    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at  http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at  http://www.tux.org/lkml/
    
    
    \
     
     \ /
      Last update: 2007-11-13 09:01    [from the cache]
    ©2003-2008